Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fastq_bwa_mem_samblaster #5582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added fastq_bwa_mem_samblaster #5582

wants to merge 1 commit into from

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented May 9, 2024

PR checklist

Closes #4909

  • Added fastq_bwa_mem_samblaster
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp GallVp requested a review from a team as a code owner May 9, 2024 21:32
@GallVp GallVp requested review from adamrtalbot and removed request for a team May 9, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot Awaiting requested review from adamrtalbot adamrtalbot is a code owner automatically assigned from nf-core/nf-test

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Ready for Review
Projects
Hackathon: May 2024
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new subworkflow: FASTQ_BWA_MEM_SAMBLASTER
1 participant
@GallVp