Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vireo to modules #5576

Merged
merged 9 commits into from May 13, 2024
Merged

Add Vireo to modules #5576

merged 9 commits into from May 13, 2024

Conversation

wxicu
Copy link
Contributor

@wxicu wxicu commented May 8, 2024

PR checklist

Add vireo to nf-core modules
Closes #5072

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@wxicu wxicu requested a review from a team as a code owner May 8, 2024 20:47
@wxicu wxicu requested review from Aratz and removed request for a team May 8, 2024 20:47
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question but otherwise it LGTM

"""
vireo \\
$input \\
-N ${n_donor} \\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is -N mandatory?

@wxicu wxicu enabled auto-merge May 13, 2024 20:19
@wxicu wxicu added this pull request to the merge queue May 13, 2024
Merged via the queue into nf-core:master with commit 1a20d4c May 13, 2024
12 checks passed
@wxicu wxicu deleted the vireo branch May 13, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

new module: vireo
2 participants