Add support for Kallisto h5 format to tximeta-tximport #5505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinin4fjords
requested changes
Apr 19, 2024
There was a problem hiding this comment.
A couple of points:
- Don't forget to change the environment.yml to keep the versions the same as the container. (sorry, bad, it's just a build so you don't need to do that)
- Do you think you could add a test for .h5 files to make sure this works and stays working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the usage of inferential replicates in Kallisto. Handling them was not previously possible, since each replicate is saved in a separate plaintext file, but there is a single
h5file which contains all of them.The according bioconda package was updated via this PR