New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metamaps/classify #5466
base: master
Are you sure you want to change the base?
Add metamaps/classify #5466
Conversation
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
…into metamaps_classify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good! Can you update the meta.yaml
too?
input[1] = UNTAR.out.untar.map { id, it -> | ||
filename = it.toString() + "/DB.fa" | ||
return [ file(filename) ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use find within the module to pick up this file, rather than trying to hardcode a path, with this you srr converting s psth to a.string which isnt ideal
@nvnieuwk Updated the |
Thank you! I'll approve once you've addressed James' suggestion :p |
Working on this now :D |
PR checklist
Closes the secode module for #1403
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda