Make use of prefix and support gzipped input #5424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gariem
commented
Apr 3, 2024
gariem
commented
- Unzip the input file if it has .gz extension
- Use the unzipped file for prediction
- Provide output according to the prefix of the input tuple
SPPearce
previously requested changes
Apr 22, 2024
|
You should delete the unzipped file, just conditionally on whether you needed to unzip. Else it'll hang around and take up space |
SPPearce
reviewed
Apr 29, 2024
- Unzip input file if it has .gz extension - Use the unzipped file for prediction - Provide output according to the prefix of the input tuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.