Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idemux test_data.config #5391

Merged
merged 9 commits into from May 13, 2024
Merged

idemux test_data.config #5391

merged 9 commits into from May 13, 2024

Conversation

jaanckae
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jaanckae jaanckae requested a review from a team as a code owner March 26, 2024 09:51
@jaanckae jaanckae requested review from SPPearce and removed request for a team March 26, 2024 09:51
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit of tidying up, almost ready to merge.

modules/nf-core/idemux/main.nf Show resolved Hide resolved
modules/nf-core/idemux/meta.yml Show resolved Hide resolved
Comment on lines +16 to +17
path "demultipexing_stats.tsv" , emit: stats
path "versions.yml" , emit: versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path "demultipexing_stats.tsv" , emit: stats
path "versions.yml" , emit: versions
path "demultipexing_stats.tsv" , emit: stats
path "versions.yml" , emit: versions

Comment on lines +31 to +46
- versions:
type: file
description: File containing software versions
pattern: "versions.yml"
- fastq:
type: file
description: Demultiplexed sample FASTQ files
pattern: "*.fastq.gz"
- undetermined:
type: file
description: Optional undetermined sample FASTQ files
pattern: "Undetermined_R?.fastq.gz"
- stats:
type: file
description: Demultiplexing Stats
pattern: "demultipexing_stats.tsv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- versions:
type: file
description: File containing software versions
pattern: "versions.yml"
- fastq:
type: file
description: Demultiplexed sample FASTQ files
pattern: "*.fastq.gz"
- undetermined:
type: file
description: Optional undetermined sample FASTQ files
pattern: "Undetermined_R?.fastq.gz"
- stats:
type: file
description: Demultiplexing Stats
pattern: "demultipexing_stats.tsv"
- fastq:
type: file
description: Demultiplexed sample FASTQ files
pattern: "*.fastq.gz"
- undetermined:
type: file
description: Optional undetermined sample FASTQ files
pattern: "Undetermined_R?.fastq.gz"
- stats:
type: file
description: Demultiplexing Stats
pattern: "demultipexing_stats.tsv"
- versions:
type: file
description: File containing software versions
pattern: "versions.yml"

@SPPearce
Copy link
Contributor

SPPearce commented May 7, 2024

@jaanckae , I can't update your branch, if you can make the two requested changes we can merge this in I think.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy once the two minor changes are made.

@SPPearce SPPearce added this pull request to the merge queue May 13, 2024
Merged via the queue into nf-core:master with commit ccdcf9c May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants