Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchR module #5359

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ArchR module #5359

wants to merge 5 commits into from

Conversation

JuliaPhilipp
Copy link

PR checklist

Was supposed to close #4375

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

This is a draft to add a module for ArchR.
The tools is quite extensive and will likely require submodules. I started on "createarrowfiles" and "adddoubletscores" during the hackathon.
"createarrowfiles" is in the testing stage but still has issues. Most significantly:
The example data (output from testing cellrangeratac) is not sufficient for testing archR (because of biology), I recommend proceeding with the test data that comes with the archR package

The most helpful part of this draft is the Dockerfile, since ArchR is not available on bioconda or bioconductor. (I ran the tests with a local docker image, not quay.io image or similar)

"adddoublescores" is mostly an outline of a submodule at this point

@JuliaPhilipp JuliaPhilipp added WIP Work in progress draft labels Mar 21, 2024
@JuliaPhilipp JuliaPhilipp requested a review from a team as a code owner March 21, 2024 09:49
@JuliaPhilipp JuliaPhilipp requested review from LeuThrAsp and removed request for a team March 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft WIP Work in progress
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

new module: ArchR
1 participant