Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new modules: Pairtools split #3628

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

new modules: Pairtools split #3628

wants to merge 13 commits into from

Conversation

nservant
Copy link
Contributor

@nservant nservant commented Jul 12, 2023 •
edited

new module for pairtools/split command

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@nservant nservant added new module Adding a new module Ready for Review labels Aug 10, 2023
@nservant nservant added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 23, 2023
@edmundmiller edmundmiller requested a review from a team as a code owner October 19, 2023 16:26
@edmundmiller edmundmiller self-requested a review October 19, 2023 16:26
@edmundmiller edmundmiller removed their request for review February 6, 2024 15:34
@SPPearce SPPearce requested a review from adamrtalbot May 10, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot Awaiting requested review from adamrtalbot

Assignees
No one assigned
Labels
new module Adding a new module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nservant @adamrtalbot @SPPearce