[WIP] add pipeline-level nf-test #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is against the
|
|
|
@nf-core-bot fix linting |
edmundmiller
approved these changes
Oct 30, 2023
| # For example: adding multiple test runs with different parameters | ||
| # Remember that you can parallelise this by using strategy.matrix | ||
| - name: Cache nf-test installation | ||
| id: cache-software |
There was a problem hiding this comment.
I think this needs a hash or something.
|
|
||
| then { | ||
| assertAll( | ||
| { assert workflow.success } |
There was a problem hiding this comment.
This is bare minimum. Added a snapshot with some of the results would be a great follow up!
There was a problem hiding this comment.
It is indeed the bare minimum, but I'm happy with that already to be honest
There was a problem hiding this comment.
You can remove this file I think 🤔
maxulysse
reviewed
Oct 31, 2023
Comment on lines
+64
to
+68
| - test | ||
| - test_nogtf | ||
| - test_affy | ||
| - test_soft | ||
| - test_maxquant |
There was a problem hiding this comment.
oh I see what you're doing there.
I'd rather have that done with different tests and snapshots, similarly to how we do with the multiple workflow tests in fetchngs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).