BUGFIX Fix conversion in CreationDialogPropertiesCreationHandler #3720
Conversation
This makes the `CreationDialogPropertiesCreationHandler` use the `convert()` method from the `NodePropertyConversionService` to provide consistent behaviour.
|
Yep, this place would be the third implementation of how to convert incoming stuff for node properties 😆 and it does things differently than the other two. |
There was a problem hiding this comment.
Hi @kdambekalns,
I ran the scenario you've described in the issue and can confirm that it works. 👍 for having consistency :)
Though I actually do believe that the property value should stick to the client's timezone, because server time may run counter to user's intent :/
|
But clients may be all over the world, so storing in one timezone and converting on output/display/use seems better. Plus, within the UI we rely on UTC… |
There was a problem hiding this comment.
Thanks for cleaning that up :D
It seems the whole thing was introduced with #2596 and never really changed since. I stumbled upon this in Neos 9 and assumed it was "special" legacy handling code but was confused that it also exists in 8.3.
I plan with Neos9 to extract this whole part with #3519 deeper into the Ui php so that each NodeCreationHandlerInteface just gets a value object with deserialized elements. That way no creation handler has to come to the idea of doing it theirselves.
|
We have stumpled upon this several times now. If we select 10:00 in the creation dialog, 11:00 will be stored (because of UTC + 1). |
This makes the
CreationDialogPropertiesCreationHandleruse theconvert()method from theNodePropertyConversionServiceto provide consistent behaviour.How to verify it
See #3719 for steps to reproduce