You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was curious about the $propertyValue === '' && !TypeHandling::isSimpleType($propertyType) part in Neos 8.3 because it seems to have gone missing in 9.0 after the ESCR adjustments.
I was curious about the
$propertyValue === '' && !TypeHandling::isSimpleType($propertyType)
part in Neos 8.3 because it seems to have gone missing in 9.0 after the ESCR adjustments.Originally it was introduced to fix bwaidelich/Wwwision.Neos.CreationDialogProperties#10
But when using the
nodePropertyConversionService
we get the$rawValue !== ''
check for free in:neos-ui/Classes/Domain/Service/NodePropertyConversionService.php
Line 87 in 01ac51c
So Neos 8.3 would even forgive us not filtering out this case and writing an empty string to the node because we handle it currently at the read site:
https://github.com/neos/neos-development-collection/blob/eada1dbfb569de6e3932b26b4b3c630401020e05/Neos.ContentRepository/Classes/Domain/Model/Node.php#L924-L931
Neos 9 on the other hand is much stricter and we must check if the original issue bwaidelich/Wwwision.Neos.CreationDialogProperties#10 will resurface.
Originally posted by @mhsdesign in #3720 (comment)
The text was updated successfully, but these errors were encountered: