New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Show the right error message if only child is published #3634
Open
pKallert
wants to merge
6
commits into
neos:9.0
Choose a base branch
from
pKallert:fix/ShowRightErrorMessages
base: 9.0
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
754c71c
Feature: Add custom error message
pKallert c72acb0
Merge branch 'neos:9.0' into fix/ShowRightErrorMessages
pKallert b6f456d
Feature: use domain exception
pKallert 29a73a1
TASK: Improve Exceptionhandling in BackendServiceController
mhsdesign b41b9d9
Merge branch '9.0' into fix/ShowRightErrorMessages
pKallert 3bfa6b1
Feature: Translate error messages
pKallert File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the error ;)
I find the pattern of rethrowing the same error class a bit odd. I see that this pattern was used also in the code above and introduced via #3468
But I like to suggest to use a generic RuntimeException and additionally pass the original exception as third parameter for both cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look and all of the exceptions are domain exceptions, so it would make more sense to rethrow that to me.
Looks like this now: