BUGFIX: Show the right error message if only child is published #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahaeslich
approved these changes
Oct 6, 2023
mhsdesign
reviewed
Oct 18, 2023
| @@ -243,6 +244,11 @@ public function publishAction(array $nodeContextPaths, string $targetWorkspaceNa | |||
| 'Node could not be published, probably because of a missing parentNode. Please check that the parentNode has been published.', | |||
| 1682762156 | |||
| ); | |||
| } catch (NodeAggregateDoesCurrentlyNotCoverDimensionSpacePoint $e) { | |||
| throw new NodeAggregateDoesCurrentlyNotCoverDimensionSpacePoint( | |||
There was a problem hiding this comment.
Thanks for improving the error ;)
I find the pattern of rethrowing the same error class a bit odd. I see that this pattern was used also in the code above and introduced via #3468
But I like to suggest to use a generic RuntimeException and additionally pass the original exception as third parameter for both cases.
There was a problem hiding this comment.
I had a look and all of the exceptions are domain exceptions, so it would make more sense to rethrow that to me.
Looks like this now:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3633
What I did
I adjusted the message that is output to the user if the parentnode does not exist in the current dimension.