Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: FEATURE: Overhaul NodeTypeManager #4999

Draft
wants to merge 6 commits into
base: 9.0
Choose a base branch
from
Draft

WIP: FEATURE: Overhaul NodeTypeManager #4999

wants to merge 6 commits into from

Conversation

bwaidelich
Copy link
Member

@bwaidelich bwaidelich commented Apr 18, 2024 •
edited

WIP because

  • This is just the initial iteration, more/better DTOs should be introduced
  • Clean up NodeType DTO
  • Allow to retrieve single node type via NodeTypesProvider
  • Move NodeTypePostprocessorInterface to Neos.Neos
  • Adjust/add rector migrations

Resolves: #4228

@github-actions github-actions bot added the 9.0 label Apr 18, 2024
@mhsdesign mhsdesign mentioned this pull request Apr 23, 2024
Open
6 tasks
@bwaidelich bwaidelich mentioned this pull request Apr 23, 2024
Open
mhsdesign
mhsdesign reviewed Apr 25, 2024
View reviewed changes
Neos.ContentRepository.Core/Classes/NodeType/ClosureNodeTypeProvider.php
/**
* @internal
*/
final class ClosureNodeTypeProvider implements NodeTypeProviderInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest LazyNodeTypeProvider::fromClosure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul 9.0 NodeTypeManager
2 participants
@bwaidelich @mhsdesign