!!! TASK: Followup #4520 NodeTypeManager should work on NodeTypeName

[mhsdesign]

#4520 (comment)

writing

$nodeTypeManager->getTetheredNodesConfigurationForNodeType($nodeTypeManager->getNodeType($nodeTypeName))

feels not right, the nodeTypeManger should just operate on NodeTypeNames
(...but we can also allow NodeType instances either way ...)

Upgrade instructions

From 8.3

- $nodeType->getAutoCreatedChildNodes();
+ $nodeTypeManager->getTetheredNodesConfigurationForNodeType($nodeType->name);

- $nodeType->hasAutoCreatedChildNode($nodeName);
+ $nodeType->hasTetheredNode($nodeName);

- $parentsNodeType->getTypeOfAutoCreatedChildNode($nodeName)->name;
+ $parentsNodeType->getNodeTypeNameOfTetheredNode($nodeName);

- $parentsNodeType->getTypeOfAutoCreatedChildNode($nodeName);
+ $nodeTypeManager->getTypeOfTetheredNode($parentsNodeType->name, $nodeName);

- $grandParentsNodeType->allowsGrandchildNodeType($parentNodeName->value, $nodeType);
+ $nodeTypeManager->isNodeTypeAllowedAsChildToTetheredNode($grandParentsNodeType->name, $parentNodeName, $nodeType->name);

From 9.x-dev

- $nodeTypeManager->getTetheredNodesConfigurationForNodeType($nodeType);
+ $nodeTypeManager->getTetheredNodesConfigurationForNodeType($nodeType->name);

- $nodeTypeManager->getTypeOfTetheredNode($parentsNodeType, $nodeName);
+ $nodeTypeManager->getTypeOfTetheredNode($parentsNodeType->name, $nodeName);

- $nodeTypeManager->isNodeTypeAllowedAsChildToTetheredNode($grandParentsNodeType, $parentNodeName, $nodeType);
+ $nodeTypeManager->isNodeTypeAllowedAsChildToTetheredNode($grandParentsNodeType->name, $parentNodeName, $nodeType->name);

Review instructions

Rector migrations will be provided as part of neos/rector#57

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[mhsdesign]

As alternative trick we can as well make these hardcore mehtods internal like who really understands isNodeTypeAllowedAsChildToTetheredNode ?? :D Usages are limited to Neos.Neos and FlowpackNodeTemplates

[mhsdesign]

Todo these rector migration would need to be adjusted so they dont pass the $nodeType to the methods, but $nodeType->name:

• NodeTypeGetAutoCreatedChildNodesRector
• NodeTypeGetTypeOfAutoCreatedChildNodeRector
• NodeTypeAllowsGrandchildNodeTypeRector

[mhsdesign]

@bwaidelich as you also currently refactor the NodeTypeManager (#4999) ... do you think we should also incorporate this change (i yet have to fix ci but just want to know if its worth the effort)

[bwaidelich]

do you think we should also incorporate this change

We'll have to since Node::nodeType will most probably be removed

[dlubitz]

Looks good in general. I stumled over the method names. Should we change them as we changed the parameter from NodeType to NodeTypeName?

E.g:
isNodeTypeAllowedAsChildToTetheredNode =>isNodeTypeNameAllowedAsChildToTetheredNode

[mhsdesign]

The 3rd param should probably be rather $nodeTypeNameInQuestion or sth

[mhsdesign]

Should we change them as we changed the parameter from NodeType to NodeTypeName?

good point but i dont think so as the thing the user of the api tries to solve if a NodeType is allowed or not ... that the node type is identified via NodeTypeName can be left out in the method name i think.

---

Another thing i just remembered is that we want to be rather forgiving (see #4954) so i dont know if all the new requireNodeType call would do us good or if they would be a pita in the future. Have to think if it makes sense to return false for booleans or just null otherwise.

[bwaidelich]

isNodeTypeAllowedAsChildToTetheredNode =>isNodeTypeNameAllowedAsChildToTetheredNode

That doesn't make sense to me. Yes, we pass in a node name but this method is about the allowed node type