Migrate Node::getNodeType

[mhsdesign]

neos/neos-development-collection#5020

Following code should be migrated:

- $node->getNodeTypeName();
+ $node->nodeTypeName;

- $node->getNodeType()->getName();
+ $node->nodeTypeName->value;

- $nodeType->getName();
+ $nodeType->name->value;

- $node->getNodeType();
+ $nodeTypeManger = ...;
+ $nodeTypeManager->getNodeType($node->nodeTypeName);

- $node->getNodeType()->getTypeOfAutoCreatedChildNode(NodeName::fromString('name'));
+ $nodeTypeManager->getTypeOfTetheredNode($node->nodeTypeName, NodeName::fromString('name'));

[mhsdesign]

@dlubitz i have the feeling that the migrations cant be possible as clean as suggested and will likely look like having an obsolete step in between (fetching the nodeType first)

- $node->getNodeType()->getName();
+ $nodeTypeManager->getNodeType($node->nodeTypeName)->name->value;

- $node->getNodeType()->getTypeOfAutoCreatedChildNode(NodeName::fromString('name'));
+ $nodeTypeManager->getTypeOfTetheredNode($nodeTypeManager->getNodeType($node->nodeTypeName)->name, NodeName::fromString('name'));

... or we can have a rector rule to normalize $nodeTypeManager->getNodeType($node->nodeTypeName)->name to $node->nodeTypeName 😂

[dlubitz]

neos/neos-development-collection#4906 (comment)

Todo these rector migration would need to be adjusted so they dont pass the $nodeType to the methods, but $nodeType->name:

• NodeTypeGetAutoCreatedChildNodesRector
• NodeTypeGetTypeOfAutoCreatedChildNodeRector
• NodeTypeAllowsGrandchildNodeTypeRector