Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Document NodeAggregate #4832

Merged
merged 5 commits into from May 14, 2024
Merged

TASK: Document NodeAggregate #4832

merged 5 commits into from May 14, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jan 14, 2024 •
edited

Related #4830

  • Adds / Improves constructor param documentation
    • and makes the constructor internal
  • Assert that a node aggregate only exists if it "has" one node (via non-empty-array
  • Assert that the InterDimensionalVariationGraph::getRootGeneralizations will always return at least one element in the array (instead of doing this at call-site) (as discussed with Bernhard)

Upgrade instructions

none

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Jan 14, 2024
@mhsdesign mhsdesign changed the title TASK Document NodeAggregate and introduce getSingleNodeIndependentOfItsDimension TASK Document NodeAggregate Feb 3, 2024
@mhsdesign mhsdesign changed the title TASK Document NodeAggregate TASK: Document NodeAggregate Mar 16, 2024
@github-actions github-actions bot added the Task label Mar 16, 2024
@nezaniel nezaniel mentioned this pull request Mar 29, 2024
Merged
6 tasks
@mhsdesign mhsdesign mentioned this pull request Mar 30, 2024
Draft
6 tasks
@mhsdesign mhsdesign force-pushed the task/documentNodeAggregate branch 2 times, most recently from 138cf9a to 31f9ffa Compare April 4, 2024 18:30
@mhsdesign mhsdesign requested a review from nezaniel May 13, 2024 18:35
nezaniel
nezaniel approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhsdesign mhsdesign merged commit 966097d into neos:9.0 May 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nezaniel nezaniel nezaniel approved these changes

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mhsdesign @nezaniel