Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Catch not completely covered node aggregates #4966

Merged
merged 1 commit into from Apr 26, 2024

Conversation

nezaniel
Copy link
Member

@nezaniel nezaniel commented Mar 29, 2024

.. when resolving structure adjustments.

Root node coverage adjustments are done via the UpdateRootNodeAggregateDimensions command, so when handling structure adjustments on root nodes, we need to stop there if the command has not been executed before, otherwise things go bad

see also #4969, where we
have to use the And the command UpdateRootNodeAggregateDimensions is executed with payload: in the feature as the test should would fail otherwise.

Upgrade instructions

none

Review instructions

none

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the 9.0 branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can only say that it works ... when i write a test like this

When I change the content dimensions in content repository "default" to:
  | Identifier | Values           | Generalizations   |
  | market     | DE, CH           | CH->DE            |
  | language   | en, de, gsw, new | gsw->de->en, new  |
Then I expect the following structure adjustments for type "Neos.ContentRepository:Root":
  | Type                     | nodeAggregateId        |
  | TETHERED_NODE_MISSING    | lady-eleonode-rootford |

i get an error

Cannot determine structure adjustments for root node type Neos.ContentRepository:Root, run UpdateRootNodeAggregateDimensions first

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by 👁️

@bwaidelich bwaidelich merged commit 7519d97 into 9.0 Apr 26, 2024
11 checks passed
@bwaidelich bwaidelich deleted the catchRootNodeAdjustments branch April 26, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants