BUGFIX: Graceful error handling if setup not completed #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
bugfix/graceFullErrorHandlingIfSetupNotCompletet
branch
from
7fc25a2
to
c51d3cd
Compare
6 tasks
mhsdesign
force-pushed
the
bugfix/graceFullErrorHandlingIfSetupNotCompletet
branch
from
c51d3cd
to
f94cecf
Compare
mhsdesign
changed the title
mhsdesign
force-pushed
the
bugfix/graceFullErrorHandlingIfSetupNotCompletet
branch
from
f94cecf
to
625eaf6
Compare
|
This pr makes #4050 obsolete. |
mhsdesign
force-pushed
the
bugfix/graceFullErrorHandlingIfSetupNotCompletet
branch
2 times, most recently
from
e728866
to
0c3b5ec
Compare
|
The Flow functional tests pass now when Neos is installed. So under that measurement the change is correct :D |
mhsdesign
commented
Feb 16, 2024
The router cache is still used in combination with our routing projection. That could possibly lead to this error when our cache flushing cant keep up, like when deleting tables :D > TODO: SITE NOT FOUND; should not happen (for address NodeAddress[...] This changes the error to point to a possible cause, the Flow_Mvc_Routing_Route Ideally our `RouterCacheHook` should always keep up.
…he cr is not setup
previously the `@package` resolving would always take place, even if not necessary, when all includes are fully specified.
… rendering fallback
The TypoScript context variable `editPreviewMode` was deprecated in favour of `${documentNode.context.currentRenderingMode.name}`
With neos 9 that again was removed in favour of the fusion global `renderingMode`.
neos#4505
After the previous adjustments the `SiteDetectionFailedException` will only be thrown in fewer cases, the only real reproducible the `/neos/content` route. The rendering group is a bit overkill only for this thing and also might swallow 500 errors that should be presented as is and not wrapped by a vibrant welcome page. The ui should be adjusted instead. neos/neos-ui#3721
mhsdesign
force-pushed
the
bugfix/graceFullErrorHandlingIfSetupNotCompletet
branch
from
0c3b5ec
to
002ee3d
Compare
mhsdesign
deleted the
bugfix/graceFullErrorHandlingIfSetupNotCompletet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4714
Resolves: #4446
Current when visiting
http://127.0.0.1:8081orhttp://127.0.0.1:8081/anythingunmatchedwithout a neos site being imported:(yes a white-screen if a site exists but no site node)
(or if you have not site the
EventSourcedFrontendNodeRoutePartHandler)Proposed:
As soon as a site exist, the fusion exception view will use the
errorpath as usual to render your custom 404 page.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions