Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neos/content throws 500 if no site exists and menu drawer is not accessible #3721

Open
mhsdesign opened this issue Feb 16, 2024 · 0 comments
Labels
9.0 Backend / Backend-API Bug Label to mark the change as bugfix

Comments

@mhsdesign
Copy link
Member

There will be a sitedetection failed exception in the neos/content route when the backend controller cannot find a site.

In 8.3 we dont have a graceful error as well only something like Site doest not exist for current user: #3182

We should probably redirect to some other available module, or at least keep the backend frame around and not destroy everything.

Originally posted by @mhsdesign in neos/neos-development-collection#4717 (comment)

@mhsdesign mhsdesign transferred this issue from neos/neos-development-collection Feb 16, 2024
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this issue Feb 16, 2024
After the previous adjustments the `SiteDetectionFailedException` will only be thrown in fewer cases, the only real reproducible the `/neos/content` route.
The rendering group is a bit overkill only for this thing and also might swallow 500 errors that should be presented as is and not wrapped by a vibrant welcome page.

The ui should be adjusted instead. neos/neos-ui#3721
neos-bot pushed a commit to neos/neos that referenced this issue Feb 16, 2024
After the previous adjustments the `SiteDetectionFailedException` will only be thrown in fewer cases, the only real reproducible the `/neos/content` route.
The rendering group is a bit overkill only for this thing and also might swallow 500 errors that should be presented as is and not wrapped by a vibrant welcome page.

The ui should be adjusted instead. neos/neos-ui#3721
@grebaldi grebaldi added Bug Label to mark the change as bugfix Backend / Backend-API 9.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Backend / Backend-API Bug Label to mark the change as bugfix
Projects
None yet
Development

No branches or pull requests

2 participants