Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Decouple NodeTypeManager from Flow #4251

Merged
merged 10 commits into from May 4, 2023
Merged

FEATURE: Decouple NodeTypeManager from Flow #4251

merged 10 commits into from May 4, 2023

Conversation

nezaniel
Copy link
Member

@nezaniel nezaniel commented May 2, 2023 •
edited by bwaidelich

This decouples the CR core, especially the node type manager, from Flow

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • [-] The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Related: #4228

@github-actions github-actions bot added the 9.0 label May 2, 2023
@skurfuerst
Copy link
Member

@nezaniel is this ready? :)

@skurfuerst skurfuerst merged commit 833d98b into 9.0 May 4, 2023
8 of 10 checks passed
@skurfuerst skurfuerst deleted the 4228-nodeTypeManagerAdjustments branch May 4, 2023 11:43
@bwaidelich bwaidelich changed the title 4228 node type manager adjustments FEATURE: Decouple NodeTypeManager from Flow May 24, 2023
@mhsdesign mhsdesign mentioned this pull request Oct 25, 2023
Closed
8 tasks
@mhsdesign mhsdesign mentioned this pull request Feb 20, 2024
Closed
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Feb 20, 2024
@mhsdesign
TASK: Remove obsolete special handling for DateTimeInterface
b9b843b 
With neos#4251 `NodeType::getDefaultValuesForProperties` doesnt return a `DateTime` anymore for dateTime default values
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Mar 1, 2024
@mhsdesign
TASK: Remove obsolete special handling for DateTimeInterface
41bc886 
With neos#4251 `NodeType::getDefaultValuesForProperties` doesnt return a `DateTime` anymore for dateTime default values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.0 Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nezaniel @skurfuerst