Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone ContentRepository.Core ! #4227

Closed
4 of 8 tasks
bwaidelich opened this issue Apr 29, 2023 · 8 comments · Fixed by #4644
Closed
4 of 8 tasks

Standalone ContentRepository.Core ! #4227

bwaidelich opened this issue Apr 29, 2023 · 8 comments · Fixed by #4644
Assignees
Labels

Comments

@bwaidelich
Copy link
Member

bwaidelich commented Apr 29, 2023

@bwaidelich bwaidelich added the 9.0 label Apr 29, 2023
@bwaidelich
Copy link
Member Author

NodeType and NodeTypeManager adjustments are related to #4228 but maybe we can already fix the Flow dependency so we are not blocked by the "rewrite"

@skurfuerst
Copy link
Member

@nezaniel is working on this I guess :) or at least he has :)

@nezaniel
Copy link
Member

#4455 should take care of the test suite dependencies

@mhsdesign
Copy link
Member

Hi what is the status on this? I think we are mostly done with this right?

@mhsdesign
Copy link
Member

I think it got an answer to it in https://github.com/skurfuerst/standalone-content-repository/tree/main ;)

We apparently still use Flows Algorithms https://github.com/skurfuerst/standalone-content-repository/blob/040d38f93950ca8fb028609c2ec03ca116ceb568/src/Workaround/FlowUtilityAlgorithms.php#L20 but that should be easy to adjust ^^

Also we must always declare 'Neos.ContentRepository:Root' as nodetype manually, maybe thats the only nodetype the manager should always know about?

https://github.com/skurfuerst/standalone-content-repository/blob/040d38f93950ca8fb028609c2ec03ca116ceb568/NodeTypes.yaml#L3C1-L3C30

@skurfuerst
Copy link
Member

@mhsdesign yeah I am thinking along the same lines :):)

@mhsdesign
Copy link
Member

mhsdesign commented Oct 25, 2023

Okay it seems our logic in here is still valid:

https://github.com/neos/flow-development-collection/blob/e60dab42b10b09a0a23fbe463c40562b10f2baeb/Neos.Flow/Classes/Utility/Algorithms.php#L37-L44

Ramsey\Uuid will not use by its own uuid_create, only if the feature is enabled (new FeatureSet(enablePecl: true)):

The question now is where to place this logic and if the core should have an utility and a dependency on ramsey/uuid?

All leftover usages:

@mhsdesign
Copy link
Member

Update it seems we already have and utility which is already used for example for NodeAggregateId::create

See

Neos\ContentRepository\Core\SharedModel\Id\UuidFactory::create

That was introduced lately with #4251 and we could use it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants