[Merton][WW] Adds configurations for bulky waste #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## merton-ww-bulky #4956 +/- ##
===================================================
- Coverage 82.69% 82.69% -0.01%
===================================================
Files 401 401
Lines 30950 30967 +17
Branches 4887 4890 +3
===================================================
+ Hits 25594 25607 +13
- Misses 3899 3904 +5
+ Partials 1457 1456 -1 ☔ View full report in Codecov by Sentry. |
dracos
force-pushed
the
merton-ww-bulky-config
branch
from
8dec216
to
5ae1178
Compare
dracos
force-pushed
the
merton-ww-bulky-config
branch
from
5ae1178
to
8288ac9
Compare
|
@MorayMySoc I've taken your idea from #4736 and used that instead, as it felt like a nicer way of doing it? I've added a fixup commit - let me know what you think about it. |
|
@dracos I think this fits better into the flow in the way everything else is working rather than being a different solution to the same problem. |
If a bulky collection hasn't been collected by 6pm on the day of collection allow reporting as missed collection. Also includes open reports from previous days, but without the 6pm limit as 6pm for their collection has already passed.
dracos
force-pushed
the
merton-ww-bulky-config
branch
from
8288ac9
to
824eb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows report missed collection on the day
https://github.com/mysociety/societyworks/issues/4270