[Merton] Initial bulky waste functionality #4924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## merton-ww-initial #4924 +/- ##
=====================================================
- Coverage 82.64% 82.63% -0.01%
=====================================================
Files 397 399 +2
Lines 30799 30895 +96
Branches 4861 4873 +12
=====================================================
+ Hits 25453 25530 +77
- Misses 3896 3904 +8
- Partials 1450 1461 +11 ☔ View full report in Codecov by Sentry. |
dracos
commented
Apr 17, 2024
dracos
force-pushed
the
merton-ww-initial
branch
from
042f796
to
1e7efcd
Compare
dracos
force-pushed
the
merton-ww-bulky
branch
3 times, most recently
from
81d1439
to
4f3d1f5
Compare
chrismytton
approved these changes
Apr 24, 2024
|
|
||
| use_ok 'Integrations::Adelante'; | ||
|
|
||
| my %sent; |
There was a problem hiding this comment.
This doesn't seem to be used anywhere, is it still needed?
Comment on lines
+742
to
+758
| wasteworks_config => { | ||
| base_price => '6075', | ||
| band1_price => '3700', | ||
| band1_max => 3, | ||
| items_per_collection_max => 6, | ||
| per_item_costs => 0, | ||
| show_location_page => 'users', | ||
| item_list => [ | ||
| { bartec_id => '83', name => 'Bath' }, | ||
| { bartec_id => '84', name => 'Bathroom Cabinet /Shower Screen' }, | ||
| { bartec_id => '85', name => 'Bicycle' }, | ||
| { bartec_id => '3', name => 'BBQ' }, | ||
| { bartec_id => '6', name => 'Bookcase, Shelving Unit' }, | ||
| ], | ||
| }, | ||
| ); | ||
| $body->update; |
There was a problem hiding this comment.
Indentation has gone slightly awry here.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mysociety-pusher
force-pushed
the
merton-ww-bulky
branch
from
8dec216
to
ee495cf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts off by renaming the various payment Roles, moving those with no relevance to FixMyStreet under Integrations/Roles directly, and moving the cobrand-based payment roles under FixMyStreet/Roles/Cobrand/. Then adds a new payment integration provider (operates very similarly to the existing SCP one). Then adds the basic bulky waste code for Merton.
For https://github.com/mysociety/societyworks/issues/4270 [skip changelog]