Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added role button to .dropzone and elements inside .fms_pan_zoom #4913

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Added role button to .dropzone and elements inside .fms_pan_zoom #4913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72cfd70
Added role='button' to .dropzone element
lucascumsille Apr 9, 2024
29d3c0a
Added role='button' to compass and zoom buttons
lucascumsille Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions templates/web/base/maps/_compass.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
%]

<div id="ns_fms_pan_zoom" style="position: absolute;" class="olControlPanZoom olControlNoSelect" unselectable="on">
<a rel="nofollow" tabindex="0" href="[% north %]"><span id="ns_fms_pan_zoom_panup" class="olButton">pan up</span></a>
<a rel="nofollow" tabindex="0" href="[% west %]"><span id="ns_fms_pan_zoom_panleft" class="olButton">pan left</span></a>
<a rel="nofollow" tabindex="0" href="[% east %]"><span id="ns_fms_pan_zoom_panright" class="olButton">pan right</span></a>
<a rel="nofollow" tabindex="0" href="[% south %]"><span id="ns_fms_pan_zoom_pandown" class="olButton">pan down</span></a>
<a rel="nofollow" tabindex="0" href="[% zoom_in %]"><span id="ns_fms_pan_zoom_zoomin" class="olButton">zoom in</span></a>
<a rel="nofollow" tabindex="0" href="[% zoom_out %]"><span id="ns_fms_pan_zoom_zoomout" class="olButton">zoom out</span></a>
<a rel="nofollow" role="button" tabindex="0" href="[% north %]"><span id="ns_fms_pan_zoom_panup" class="olButton">pan up</span></a>
<a rel="nofollow" role="button" tabindex="0" href="[% west %]"><span id="ns_fms_pan_zoom_panleft" class="olButton">pan left</span></a>
<a rel="nofollow" role="button" tabindex="0" href="[% east %]"><span id="ns_fms_pan_zoom_panright" class="olButton">pan right</span></a>
<a rel="nofollow" role="button" tabindex="0" href="[% south %]"><span id="ns_fms_pan_zoom_pandown" class="olButton">pan down</span></a>
<a rel="nofollow" role="button" tabindex="0" href="[% zoom_in %]"><span id="ns_fms_pan_zoom_zoomin" class="olButton">zoom in</span></a>
<a rel="nofollow" role="button" tabindex="0" href="[% zoom_out %]"><span id="ns_fms_pan_zoom_zoomout" class="olButton">zoom out</span></a>
</div>
2 changes: 1 addition & 1 deletion web/cobrands/fixmystreet/fixmystreet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ $.extend(fixmystreet.set_up, {
var $originalInputs = $('#form_photos, .js-photo-fields', $context);
$originalInputs.each(function() {
var $originalInput = $(this);
var $dropzone = $('<div tabindex=0>').addClass('dropzone');
var $dropzone = $('<div tabindex=0 role="button">').addClass('dropzone');
var $fileid_input = $originalInput.data('upload-field') || 'upload_fileid';
var max_photos = !isNaN($originalInput.data('max-photos')) ? $originalInput.data('max-photos') : 3;

Expand Down
1 change: 1 addition & 0 deletions web/js/map-OpenLayers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,6 +1096,7 @@ OpenLayers.Control.PanZoomFMS = OpenLayers.Class(OpenLayers.Control.PanZoom, {
btn.action = id;
btn.className = "olButton";
btn.tabIndex = "0";
btn.role = "button";
this.div.appendChild(btn);
this.buttons.push(btn);
return btn;
Expand Down