Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added role button to .dropzone and elements inside .fms_pan_zoom #4913

Merged
merged 2 commits into from Apr 30, 2024

Conversation

lucascumsille
Copy link
Contributor

Fixes: https://github.com/mysociety/societyworks/issues/4218

This PR improves UX for users using assistive devices.

[Skip changelog]

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (e7adc01) to head (b8a1276).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4913      +/-   ##
==========================================
- Coverage   85.38%   82.64%   -2.74%     
==========================================
  Files         349      391      +42     
  Lines       25529    30610    +5081     
  Branches     4838     4838              
==========================================
+ Hits        21798    25298    +3500     
- Misses       2274     3853    +1579     
- Partials     1457     1459       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good to spot the JS based creation one :)

@lucascumsille lucascumsille merged commit 29d3c0a into master Apr 30, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants