Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to not including git hash in build for non ACCESS-OM2 models #384

Merged
merged 4 commits into from Aug 8, 2023

Conversation

aidanheerdegen
Copy link
Contributor

Removed adding a version hash to every build with the exception of ACCESS-OM* models.

Added --no_version option to also not include version hash in ACCESS-OM builds.

This is necessary because it prevents all of the model types from building outside of a git repository (see #308).

Being able to build from a tarball is desirable for a number of reasons:

  1. The code is available as tarballs directly from GitHub
  2. Tarballs are the standard way of release code in packages on GitHub
  3. spack needs to be able to access code as a tarball from GitHub to enable building specific versions (Is it possible for CI to function if only the git URL is in the SPD? ACCESS-NRI/spack-packages#32), and spack has it's own versioning

Closes #308

@aidanheerdegen
Copy link
Contributor Author

Hey @aekiss can you take a look and let me know that you're happy for me to merge this?

The idea is it shouldn't affect COSIMA ACCESS-OM2 builds, but will remove the git hash versioning from all other models, and optionally from ACCESS-OM2 if the --no_version flag is used with the ./MOM_compiler.csh script.

CI Compilation was happy enough, but I am testing with a full compile on gadi, with and without the --no_version option. Will report the results when they're complete.

@aidanheerdegen
Copy link
Contributor Author

aidanheerdegen commented Aug 4, 2023

Yeah gadi tests are ok. Now to do the same with libaccessom2 ...

exp/MOM_compile.csh Outdated Show resolved Hide resolved
Copy link
Collaborator

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one typo in a comment

Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
@aidanheerdegen aidanheerdegen merged commit d7ba13a into master Aug 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building outside a git repository fails.
2 participants