Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MOM5 package to use new option to not use git commit hash versioning #35

Closed
aidanheerdegen opened this issue Aug 4, 2023 · 2 comments
Assignees

Comments

@aidanheerdegen
Copy link
Contributor

This PR adds the ability to build MOM5 in ACCESS-OM2 without the git hash versioning

mom-ocean/MOM5#384

Once it is merged to take advantage of that the --no_version option would need to be added here:

https://github.com/ACCESS-NRI/spack_packages/blob/cice5/packages/mom5/package.py#L307-L311

It should probably be made conditional on MOM5 version. Or specify that MOM5 must be that version or greater to build.

@harshula harshula self-assigned this Nov 10, 2023
@harshula
Copy link
Collaborator

PR #51 for --no_version.
It's not conditional at the moment, but we probably need to make all the SPDs conditional on the new tags that have been introduced.

@aidanheerdegen
Copy link
Contributor Author

Closed by #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants