Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License and Maven update #242

Merged
merged 4 commits into from Mar 20, 2024
Merged

Conversation

antoinesd
Copy link
Contributor

fixes #241
Update license to remove year and apply it to existing files
Update Maven version to 3.9.6
Update Maven dependencies and plugin to last non-breaking version

etc/license.txt Outdated Show resolved Hide resolved
Copy link
Member

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM. Any idea though what's wrong with that failing test?

@antoinesd
Copy link
Contributor Author

antoinesd commented Mar 18, 2024

Any idea though what's wrong with that failing test?

Hello @gunnarmorling. If you are referring the 4 occurrences of

[ERROR] Error occurred during initialization of boot layer
[ERROR] java.lang.module.FindException: Module com.example not found

It seems to come from the @Before method in the test which is doing deletion in target folder :
[WARNING] Corrupted channel by directly writing to native stream in forked JVM 1
I'll try to investigate.

For the record, the error was already there before this PR and the update of the surefire plugin. It was just less visible (only present in the surefire dump file)

@antoinesd
Copy link
Contributor Author

@aalmiray @gunnarmorling Are you ok to merge this PR ? I need it to rebase my 2 other PR and fix 3rd example

@aalmiray
Copy link
Contributor

@antoinesd what do we do with the failing test? In the past those errors did not fail the build, did they?

@antoinesd
Copy link
Contributor Author

antoinesd commented Mar 19, 2024

@aalmiray did you read my comment ? These error were here before. The only change is that this new version of surefire plugin shows them explicitly in the console and not only in the file target/surefire-report/2024-***-jvmRun1.dumpstream file. If it's very problematic to see them, we can revert to previous surefire plugin version but we'll have to deal with this error anyway.

@aalmiray
Copy link
Contributor

Yes, I read the comment. And at first I thought it was just error messages being displayed in a different way. But now the build also breaks snd that is what concerns me. Yes, the code was broken before but the build continued (which is wrong of course). Now the build breaks as it should, so we have to find a way to fix it.

@antoinesd
Copy link
Contributor Author

antoinesd commented Mar 20, 2024

@aalmiray @gunnarmorling ok, got it! It was a misunderstanding (a bug between my chair and keyboard in fact) because on my Mac the build was always failing at Vert.x example due to my antivirus preventing the usage of log4j 2.8 that contains the log4shell vulnerability.
After disabling my antivirus I have the build working on master (even if doesn't produce any usable jlink images). Updating the maven version lot 3.9.6 breaks it.
What I suggest is to merge this PR with #238 and enhance the resulting PR with fix for hibernate validator example as well.
After that maven should be updated with most plugins up to date and the build should work (with usable link images).the other solution is to move maven update in another PR with all the fixes to existing example.
Wdyt?

@aalmiray
Copy link
Contributor

@antoinesd Alright! Let's do that. I'll merge both PRs.

@aalmiray aalmiray merged commit 25ef0e4 into moditect:main Mar 20, 2024
1 check failed
@antoinesd antoinesd deleted the license-mvn-updates branch March 25, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update license and maven configuration
3 participants