New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License and Maven update #242
Conversation
…e starnge dependecies issues while resolving module-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, LGTM. Any idea though what's wrong with that failing test?
Hello @gunnarmorling. If you are referring the 4 occurrences of
It seems to come from the For the record, the error was already there before this PR and the update of the surefire plugin. It was just less visible (only present in the surefire dump file) |
@aalmiray @gunnarmorling Are you ok to merge this PR ? I need it to rebase my 2 other PR and fix 3rd example |
@antoinesd what do we do with the failing test? In the past those errors did not fail the build, did they? |
@aalmiray did you read my comment ? These error were here before. The only change is that this new version of surefire plugin shows them explicitly in the console and not only in the file |
Yes, I read the comment. And at first I thought it was just error messages being displayed in a different way. But now the build also breaks snd that is what concerns me. Yes, the code was broken before but the build continued (which is wrong of course). Now the build breaks as it should, so we have to find a way to fix it. |
@aalmiray @gunnarmorling ok, got it! It was a misunderstanding (a bug between my chair and keyboard in fact) because on my Mac the build was always failing at |
@antoinesd Alright! Let's do that. I'll merge both PRs. |
fixes #241
Update license to remove year and apply it to existing files
Update Maven version to 3.9.6
Update Maven dependencies and plugin to last non-breaking version