Adding a new example based on CDI 4 #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalmiray
requested changes
Mar 15, 2024
aalmiray
requested changes
Mar 25, 2024
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.12.1</version> |
There was a problem hiding this comment.
We probably should use latest which is 3.13.0. Please define a property in the parent pom that overrides this value https://github.com/moditect/moditect-org-parent/blob/b825070b22eec75ae8f965dfd7fd5e01898fc8bf/pom.xml#L56
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <version>3.6.1</version> |
There was a problem hiding this comment.
Also update this property in the parent pom https://github.com/moditect/moditect-org-parent/blob/b825070b22eec75ae8f965dfd7fd5e01898fc8bf/pom.xml#L57
|
@antoinesd requested changes only require adding 2 properties to https://github.com/moditect/moditect/blob/main/parent/pom.xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #237.
This example created for a talk could be useful to help other using moditect. It introduces a simple CDI SE app and is showing how to deal with already modularized dependencies (all Jakarta EE 10 api are JPMS ready)