Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vert.x and Hibernate validator examples #238

Merged
merged 8 commits into from Mar 23, 2024
Merged

Fix Vert.x and Hibernate validator examples #238

merged 8 commits into from Mar 23, 2024

Conversation

antoinesd
Copy link
Contributor

@antoinesd antoinesd commented Mar 15, 2024 •
edited

fixes #206
JLink image (in JLink profile) is now working. Produced image is also functioning.

aalmiray
aalmiray reviewed Mar 15, 2024
View reviewed changes
integrationtest/vert.x/pom.xml Show resolved Hide resolved
integrationtest/vert.x/pom.xml Outdated Show resolved Hide resolved
@antoinesd
Copy link
Contributor Author

antoinesd commented Mar 15, 2024 •
edited

BTW, the docker part of the example is still not working at the moment.
I also tried to update Vert.x and Netty version but it brought a lot of new corner cases.
I'll try to fix these later if the PR is merged

@antoinesd antoinesd mentioned this pull request Mar 20, 2024
Merged
@aalmiray
Copy link
Contributor

@antoinesd could you rebase from your side? I thought I could fix a merge conflict from mine side but something went wrong, sorry 😓

@antoinesd
Add --ignore-missing-deps to Vertx pom to prevent modules error from …
e8a060c 
…optional dependencies

Add NONE as JarInclusionPolicy to prevent failure while creating the image
@antoinesd
Change in plugin configuration and order of declared modules to obtai…
3b609a4 
…n a fonctionning jlink image
@antoinesd
includes reviewer remark on opening all the module: changed it to an …
b57ec57 
…exports directive
@antoinesd antoinesd changed the title Fix Vert.x example Fix Vert.x and Hibernate validator examples Mar 20, 2024
@antoinesd
Copy link
Contributor Author

I force-pushed, changed the title and I'm working on resolving build failure for hibernate validator example

@antoinesd
Copy link
Contributor Author

@aalmiray, @gunnarmorling : Now the build pass.

  • I corrected all license mention even in the files not covered by the licence plugin,
  • I removed parent pom path and packaging from examples
  • and last but not least (the most brain f*** part) I updated Hibernate Validator example to Jakarta EE 10 and make it pass the build (didn't try to launch the resulting artifact : not sure what is expected with this test)

aalmiray
aalmiray requested changes Mar 21, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
integrationtest/hibernate-validator/pom.xml Outdated Show resolved Hide resolved
integrationtest/hibernate-validator/pom.xml Outdated Show resolved Hide resolved
integrationtest/vert.x/pom.xml Show resolved Hide resolved
@aalmiray
Copy link
Contributor

LGTM @gunnarmorling do you have any additional comments?

@aalmiray aalmiray merged commit 80c1c1d into moditect:main Mar 23, 2024
1 check passed
@antoinesd antoinesd deleted the moditect-206 branch March 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalmiray aalmiray aalmiray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build vert.x example
2 participants
@antoinesd @aalmiray