Prevent Reaction From Keeping a Reference to The OldValue #3812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI Folks
This PR is about
reaction
and memory retainment preventing object beeing garbage collectedFor some reason, the
reactionRunner
of a reaction creates a closure around anoldValue
and so the reference to theoldValue
is kept untill a newValue is computed.I can see no reason for keeping such a reference "alive",
oldValue
could just be declared in the scope of thereactionRunner
as it is the only place where it is used. Doing so, theoldValue
can be garbage collected if needed.No additional Unit test is needed for such a change, and there is no backward compatibility issue as it only touches internal/private stuff within a
reaction
.