Prevent Reaction From Keeping a Reference to The OldValue (#3812)

mobxjs · Jan 10, 2024 · 620f78c · 620f78c
1 parent 55260aa
commit 620f78c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/six-pugs-impress.md b/.changeset/six-pugs-impress.md
@@ -0,0 +1,5 @@
+---
+"mobx": patch
+---
+
+Prevent `reaction` from heeping a Reference to the OldValue that would prevent GC.
diff --git a/packages/mobx/src/api/autorun.ts b/packages/mobx/src/api/autorun.ts
@@ -139,7 +139,6 @@ export function reaction<T, FireImmediately extends boolean = false>(
     let firstTime = true
     let isScheduled = false
     let value: T
-    let oldValue: T | undefined
 
     const equals: IEqualsComparer<T> = (opts as any).compareStructural
         ? comparer.structural
@@ -165,10 +164,10 @@ export function reaction<T, FireImmediately extends boolean = false>(
             return
         }
         let changed: boolean = false
+        const oldValue = value
         r.track(() => {
             const nextValue = allowStateChanges(false, () => expression(r))
             changed = firstTime || !equals(value, nextValue)
-            oldValue = value
             value = nextValue
         })