New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dhcp option parsing fixes #48
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1101590
FIX MTU PARSING :D :D :D
yomimono 29fbf4b
dorp dorp dorp
yomimono 7798be7
Typefix in client; better MTU fix in option
yomimono 5ba92bd
dhcpv4_option.ml: make function get_number for variable-size int reads
yomimono ca91689
dhcpv4_option: fix parsing crash when option max-size is set
yomimono f673b26
dhcp_clientv4.ml and dhcpv4_option.ml: removed debug output
yomimono db66064
dhcp_clientv4.ml : clean up chaddr printing
yomimono 40ff6e7
dhcp_clientv4.ml : revert unnecessary variable name change
yomimono 71b875f
dhcp_clientv4.ml : remove some unnecessary changes
yomimono File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear what we should do with the MTU; I've opened up mirage/mirage#238