Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dhcp option parsing fixes #48

Merged
merged 9 commits into from Mar 27, 2014
Merged

Dhcp option parsing fixes #48

merged 9 commits into from Mar 27, 2014

Commits on Mar 21, 2014

  1. FIX MTU PARSING :D :D :D

    yomimono committed Mar 21, 2014
    Copy the full SHA
    1101590 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2014

  1. dorp dorp dorp

    yomimono committed Mar 25, 2014
    Copy the full SHA
    29fbf4b View commit details
    Browse the repository at this point in the history
  2. Typefix in client; better MTU fix in option

    dhcp_clientv4.ml would not build because of a type error;
    copy_dhcp_chaddr needed to be used, instead of get_dhcp_chaddr, as an
    argument to the function which generates a human-readable string from
    the raw hex.
    
    dhcpv4_option.ml now parses variable-length MTU options correctly,
    although it seems that unikernels don't respect this value and will send
    unfragmented packets of size greater than the transmitted MTU.
    yomimono committed Mar 25, 2014
    Copy the full SHA
    7798be7 View commit details
    Browse the repository at this point in the history
  3. dhcpv4_option.ml: make function get_number for variable-size int reads

    Some DHCP options require number parsing for buffers of specified sizes.
    Of the DHCP options currently supported, only MTU parsing requires this;
    however, future options may require it as well.
    yomimono committed Mar 25, 2014
    Copy the full SHA
    5ba92bd View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    ca91689 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    f673b26 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    db66064 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    40ff6e7 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    71b875f View commit details
    Browse the repository at this point in the history