Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url with query params #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrloop
Copy link

@mrloop mrloop commented Mar 12, 2021

This PR will correctly construct a URL where the ember-api-action path
contains query params and/or where the ember data adapter buildURL
returns a url containing query params.

Fixes #414

@mrloop mrloop force-pushed the em-query-params branch 2 times, most recently from 6315e27 to 7bbf27a Compare March 22, 2021 19:40
@mrloop mrloop mentioned this pull request Mar 22, 2021
@sandstrom
Copy link

friendly ping @mike-north @Turbo87 @alexlafroscia

This PR will correctly construct a URL where the ember-api-action path
contains query params and/or where the ember data adapter buildURL
returns a url containing query params.

Fixes mike-north#414
@mrloop mrloop force-pushed the em-query-params branch 2 times, most recently from 8c81fc3 to c551166 Compare July 9, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Url is not build properly when there is a query params in the adapter buildUrl method.
2 participants