feat: adapterOptions #510
Open
feat: adapterOptions #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrloop
force-pushed
the
em-adapter-options
branch
from
1720010
to
be19fe5
Compare
|
friendly ping @mike-north @Turbo87 @alexlafroscia |
This PR will correctly construct a URL where the ember-api-action path contains query params and/or where the ember data adapter buildURL returns a url containing query params. Fixes mike-north#414
Allows api actions to take an optional `options` object. If you pass an object on the adapterOptions property of the options argument it will be passed to your adapter via the snapshot. Similar to ember data Store and Modal functions, for example https://api.emberjs.com/ember-data/3.25/classes/Store/methods/findAll?anchor=findAll https://api.emberjs.com/ember-data/3.25/classes/Model/methods/save?anchor=save This is similar to mike-north#214 with tests. Closes mike-north#214
mrloop
force-pushed
the
em-adapter-options
branch
2 times, most recently
from
5baceeb
to
09e647d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows api actions to take an optional
optionsobject. If you pass anobject on the adapterOptions property of the options argument it will be
passed to your adapter via the snapshot.
Relies on #506 - this is first commit in this PR. This PR will be easier to review once #506 is merged.
Similar to ember data Store and Model functions, for example
https://api.emberjs.com/ember-data/3.25/classes/Store/methods/findAll?anchor=findAll
https://api.emberjs.com/ember-data/3.25/classes/Model/methods/save?anchor=save
This is similar to #214 with tests.
Closes #214