Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Drop python 39 #5620

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

RFC: Drop python 39 #5620

wants to merge 9 commits into from

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jan 4, 2024

Most of the scientific python stack has adopted SPEC 0 which means that python 3.9 support should be dropped from late 2023. As an example we can see in #5602 that Ipython has dropped support for 3.9.

This is to propose that QCoDeS also drops support for 3.9

  • This should also update the readme
  • Remove 3.9 ci jobs

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #5620 (92df777) into main (150d405) will decrease coverage by 0.04%.
The diff coverage is 85.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5620      +/-   ##
==========================================
- Coverage   66.39%   66.36%   -0.04%     
==========================================
  Files         354      354              
  Lines       30965    30964       -1     
==========================================
- Hits        20560    20549      -11     
- Misses      10405    10415      +10     

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 85.33333% with 44 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (07351c1) to head (032df8f).

Current head 032df8f differs from pull request most recent head c57cd3a

Please upload reports for the commit c57cd3a to get more accurate results.

Files Patch % Lines
src/qcodes/instrument_drivers/Galil/dmc_41x3.py 7.69% 12 Missing ⚠️
..._drivers/AlazarTech/ATS_acquisition_controllers.py 25.00% 3 Missing ⚠️
...ent_drivers/signal_hound/SignalHound_USB_SA124B.py 50.00% 3 Missing ⚠️
src/qcodes/instrument_drivers/Keysight/KtMAwg.py 50.00% 2 Missing ⚠️
...des/instrument_drivers/Minicircuits/USBHIDMixin.py 60.00% 2 Missing ⚠️
...ent_drivers/QuantumDesign/DynaCoolPPMS/DynaCool.py 50.00% 2 Missing ⚠️
...rc/qcodes/instrument_drivers/rigol/Rigol_DG1062.py 50.00% 2 Missing ⚠️
src/qcodes/instrument_drivers/tektronix/AWG5014.py 60.00% 2 Missing ⚠️
...odes/instrument_drivers/tektronix/AWGFileParser.py 50.00% 2 Missing ⚠️
src/qcodes/instrument_drivers/yokogawa/GS200.py 33.33% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5620      +/-   ##
==========================================
- Coverage   67.09%   67.07%   -0.03%     
==========================================
  Files         352      352              
  Lines       32035    32025      -10     
==========================================
- Hits        21494    21480      -14     
- Misses      10541    10545       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exciting :) and removing 3.9 ci and updating readme is still todo

@jenshnielsen jenshnielsen force-pushed the drop_python_39 branch 3 times, most recently from cd9396a to f402187 Compare June 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants