Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept sequences of values for setting MultiChannelInstrumentParameter #6073

Conversation

thangleiter
Copy link
Contributor

As of now, the MultiChannelInstrumentParameter is inconsistent; its setter does not accept the values returned by its getter as the first accepts a scalar ParamRawDataType, but the last returns a tuple thereof. This is particularly problematic as it breaks the set_to context manager.

This proposed change modifies the setter to allow both the current scalar behavior as well as a sequence, in which case it is zipped together with self._channels.

@thangleiter thangleiter requested a review from a team as a code owner May 15, 2024 13:27
@thangleiter
Copy link
Contributor Author

@microsoft-github-policy-service agree company="RWTH Aachen University"

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (e606790) to head (65069d2).
Report is 170 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6073      +/-   ##
==========================================
+ Coverage   67.55%   67.65%   +0.10%     
==========================================
  Files         351      352       +1     
  Lines       30492    30765     +273     
==========================================
+ Hits        20598    20814     +216     
- Misses       9894     9951      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 27, 2024
Merged via the queue into microsoft:main with commit a01c543 May 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants