MBS-13558 (II): Migrate React report components to Flow component syntax #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
flow-component-syntax-reports
branch
from
3645908
to
9a43c68
Compare
reosarevok
changed the title
reosarevok
force-pushed
the
flow-component-syntax-reports
branch
from
9a43c68
to
85d8229
Compare
yvanzo
reviewed
May 15, 2024
See the component syntax docs, and especially https://flow.org/en/docs/react/component-syntax/#destructuring-parameters which we use so we can still use the existing shared types more easily rather than adding the typing specifically in each component declaration.
reosarevok
force-pushed
the
flow-component-syntax-reports
branch
from
85d8229
to
387d8b7
Compare
yvanzo
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow now supports a specific React Component Syntax which reduces the amount of types we need to define manually, and is supposed to be better for type checking as well. I'm converting our React components to this syntax bit by bit with this PR.
This changes all stuff in the
reportsubfolder.Note: To be reviewed without whitespace changes (since this adds explicit
return()calls that require spacing things one more tab in many cases).On top of #3225