Migrate React edit components to Flow component syntax #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
flow-component-syntax-edits
branch
from
5f77f3f
to
dc62b46
Compare
reosarevok
force-pushed
the
flow-component-syntax-edits
branch
from
dc62b46
to
aa4f488
Compare
reosarevok
force-pushed
the
flow-component-syntax-edits
branch
from
aa4f488
to
aaae02f
Compare
yvanzo
approved these changes
May 16, 2024
For VoteCheckbox in Vote.js, Flow was unhappy with us passing a generic ...props to the input, since in theory the props can contain different name, type etc from what we're passing separately. This just changes it to pass value specifically, which seems to be the intention based on Flow typing.
reosarevok
force-pushed
the
flow-component-syntax-edits
branch
from
aaae02f
to
d508023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow now supports a specific React Component Syntax which reduces the amount of types we need to define manually, and is supposed to be better for type checking as well. I'm converting our React components to this syntax bit by bit with this PR.
This changes all stuff in the
editsubfolder.Note: To be reviewed without whitespace changes (since this adds explicit
return()calls that require spacing things one more tab in many cases).On top of #3226