Add table view count column and increment it on views #41886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calherries
force-pushed
the
table-view-count-column
branch
from
024a9a8
to
5397cf7
Compare
|
calherries
force-pushed
the
table-view-count-column
branch
from
5397cf7
to
61089ae
Compare
tsmacdonald
reviewed
Apr 30, 2024
src/metabase/integrations/slack.clj
Outdated
| @@ -324,6 +324,8 @@ | |||
| filename :- ms/NonBlankString | |||
| channel-id :- ms/NonBlankString] | |||
| {:pre [(slack-configured?)]} | |||
| ;; see the python | |||
| ;; https://github.com/slackapi/python-slack-sdk/pull/1272/files#diff-43db19ac0a29454cd1da520664806b266d75a54632e9661cc131406b3270b040R3066 | |||
There was a problem hiding this comment.
with the changes to the other PR maybe we don't want this any more?
There was a problem hiding this comment.
Yes this was in here by accident. deleted! a8dfedc
tsmacdonald
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: #38229
Technical doc
Does the same as part 1 and 2 but for tables. Tables was omitted from the original spec, but we decided to include it.
Part 1: #41840
Part 2: #41882
With this PR, we add a new column
metabase_table.view_countand increment it on a table view, following the same criteria for a view as we do for adding new entries toview_log.