New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment view_count on card, dashboard, and table views #41882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `view_count` column to both `report_card` and `report_dashboard`.
calherries
added
the
backport
Automatically create PR on current release branch on merge
label
Apr 26, 2024
calherries
changed the title
Increment view_count columns on card and dashboard views
Increment view_count on card and dashboard views
Apr 26, 2024
|
tsmacdonald
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me ⛵
calherries
changed the title
Increment view_count on card and dashboard views
Increment view_count on card, dashboard, and table views
Apr 30, 2024
(I accidentally merged the downstream branch into this one, so I'll wait for CI and merge this PR in to save on admin effort) |
@calherries Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Automatically create PR on current release branch on merge
no-backport
Do not backport this PR to any branch
.Team/BackendComponents
also known as BEC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: #38229
Technical doc
Previously: #41840
With this PR, we
report_card.view_count
,report_dashboard.view_count
, andmetabase_table.view_count
if cards, dashboards, and tables are viewed respectively. Before this the column was not being updated at all.I've deliberately coupled the code that currently updates
view_log
with the new code that updates theview_count
column because we decided to keep these two in sync to avoid confusing discrepancies between them, and lower the risk them getting out of sync in the future.That means we count: