Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kondo hook so LSP can jump to driver definition #41856

Merged
merged 1 commit into from May 1, 2024

Conversation

camsaul
Copy link
Member

@camsaul camsaul commented Apr 25, 2024

LSP can now jump to the place a driver like :h2 or :postgres or :metabase.driver.sql-jdbc.execute.legacy-impl/use-legacy-classes-for-read-and-set gets registered

@camsaul camsaul added the no-backport Do not backport this PR to any branch label Apr 25, 2024
@camsaul camsaul requested a review from a team April 25, 2024 22:41
@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label Apr 25, 2024
Copy link

replay-io bot commented Apr 25, 2024

Status In Progress ↗︎ 53 / 54
Commit 40b8ac0
Results
⚠️ 8 Flaky
2424 Passed

@camsaul camsaul enabled auto-merge (squash) May 1, 2024 00:28
@camsaul camsaul merged commit 2b5d207 into master May 1, 2024
117 of 137 checks passed
@camsaul camsaul deleted the kondo-jump-to-driver-definition branch May 1, 2024 00:49
Copy link

github-actions bot commented May 1, 2024

@camsaul Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants