Add kondo hook so LSP can jump to driver definition (#41856)

metabase · May 1, 2024 · 2b5d207 · 2b5d207
1 parent 7ed6b66
commit 2b5d207
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/.clj-kondo/config.edn b/.clj-kondo/config.edn
@@ -527,6 +527,7 @@
    metabase.db.schema-migrations-test.impl/test-migrations                                                                   hooks.metabase.db.schema-migrations-test.impl/test-migrations
    metabase.dashboard-subscription-test/with-link-card-fixture-for-dashboard                                                 hooks.common/let-second
    metabase.driver.bigquery-cloud-sdk-test/calculate-bird-scarcity                                                           hooks.metabase.query-processor-test.expressions-test/calculate-bird-scarcity
+   metabase.driver/register!                                                                                                 hooks.metabase.driver/register!
    metabase.legacy-mbql.schema.macros/defclause                                                                              hooks.metabase.legacy-mbql.schemas.macros/defclause
    metabase.lib.schema.mbql-clause/define-mbql-clause                                                                        hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
    metabase.lib.schema.mbql-clause/define-catn-mbql-clause                                                                   hooks.metabase.lib.schema.mbql-clause/define-mbql-clause

diff --git a/.clj-kondo/hooks/metabase/driver.clj b/.clj-kondo/hooks/metabase/driver.clj
@@ -0,0 +1,18 @@
+(ns hooks.metabase.driver
+  (:require
+   [clj-kondo.hooks-api :as api]))
+
+(defn register!
+  "Register the driver keyword so LSP can jump to it."
+  [x]
+  (letfn [(update-driver-keyword [k]
+            (api/reg-keyword! k 'metabase.driver/register!))
+          (update-children [[_register! k :as children]]
+            (if (api/keyword-node? k)
+              (update (vec children) 1 update-driver-keyword)
+              children))
+          (update-node [node]
+            (if (api/list-node? node)
+              (update node :children update-children)
+              node))]
+    (update x :node update-node)))