Add hostname support to snowflake #39471
Conversation
|
@vieux Can you make this selection automatic? If you can come up with regex rules or something to use a single field for account/hostname, it will be easier to merge the PR. Automatic selection is likely how we would implement internally. |
|
If automatic selection is really not possible, we would likely implement a toggle close to the account/hostname field |
|
@luizarakaki I'm not sure how to have a 100% reliable automatic selection since "account" can use several formats (with and without I'll take a stab at implementing a toggle |
|
@luizarakaki @qnkhuat I updated the PR, please take another look, thanks! |
|
The UI is similar to the MongoDB driver with the connection uri. |
vieux
changed the title
|
Thanks @vieux, the UI looks good. I'll ask for a code review. |
There was a problem hiding this comment.
I can't really comment about the TS code, I'm assuming it's more or less a copy of DatabaseConnectionSectionField.
What's the argument for implementing opt-out instead of opt-in? Opt-in feels more natural for me and I think the code at line 135 of modules/drivers/snowflake/src/metabase/driver/snowflake.clj would be ever so slightly more readable.
It looks good to me otherwise, I have only some trivial remarks. 👍 I'll go ahead and run the tests internally.
modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
Outdated
Show resolved
Hide resolved
modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
Outdated
Show resolved
Hide resolved
Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
|
frontend code looks good to me 👍 |
* Add alternative hostname support to snowflake * move hostname support out of additional details * Update modules/drivers/snowflake/src/metabase/driver/snowflake.clj Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Update modules/drivers/snowflake/src/metabase/driver/snowflake.clj Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Update modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * opt-in --------- Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
* Add alternative hostname support to snowflake * move hostname support out of additional details * Update modules/drivers/snowflake/src/metabase/driver/snowflake.clj * Update modules/drivers/snowflake/src/metabase/driver/snowflake.clj * Update modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj * opt-in ---------
Closes #22133
Description
Add an hostname support to snowflake. When set, it will be used instead of
<account_name>.snowflakecomputing.comHow to verify
Describe the steps to verify that the changes are working as expected.
Use hostnameand set an hostname.Demo
then, when Use hostname is clickedChecklist