Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #39471 #40385

Merged
merged 1 commit into from Mar 20, 2024
Merged

Backport #39471 #40385

merged 1 commit into from Mar 20, 2024

Conversation

metamben
Copy link
Contributor

@metamben
Add hostname support to snowflake (#39471)
7d0c36a 
* Add alternative hostname support to snowflake

* move hostname support out of additional details

* Update modules/drivers/snowflake/src/metabase/driver/snowflake.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Update modules/drivers/snowflake/src/metabase/driver/snowflake.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Update modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* opt-in

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
@metamben metamben added do not merge was-backported apply this to PRs that are themselves backports labels Mar 20, 2024
@metamben metamben self-assigned this Mar 20, 2024
@metamben metamben requested a review from camsaul as a code owner March 20, 2024 16:50
@metamben metamben modified the milestone: 0.49.1 Mar 20, 2024
@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label Mar 20, 2024
@replay-io replay.io
Copy link

replay-io bot commented Mar 20, 2024 •
edited

Status In Progress ↗︎ 51 / 52
Commit 7d0c36a
Results
⚠️ 2 Flaky
✅ 2345 Passed

@luizarakaki luizarakaki self-requested a review March 20, 2024 17:06
@metamben metamben merged commit 54ef5e9 into release-x.49.x Mar 20, 2024
113 of 114 checks passed
@metamben metamben deleted the backport-39471 branch March 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizarakaki luizarakaki luizarakaki approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@metamben metamben

Labels
do not merge .Team/QueryProcessor :hammer_and_wrench: was-backported apply this to PRs that are themselves backports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@metamben @luizarakaki