Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly release lock on all scale checks #7255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Properly release lock on all scale checks #7255

wants to merge 1 commit into from

Commits on Oct 28, 2020

  1. Properly release lock on all scale checks 

    Scale checks are done regularly, to validate that running instances
number matches expected number of instances in runSpec.

There are two cases:
* There are missing instances, in that case marathon starts new
  instances
* There are too many instances, in that case marathon kills overdue
  instances

In second case, lock is supposed to be released only when overdue instances
are dead. We encountered issues where lock was never released because
KillStreamWatKillStreamWatcher.watchForKilledTasks() future was never
ending. This is because of a typo in the code, making it wait for ALL
instances to die, instead of just the overdue subset.
    @Lqp1
    Lqp1 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    8a036d6 View commit details
    Browse the repository at this point in the history