Properly release lock on all scale checks #7255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scale checks are done regularly, to validate that running instances number matches expected number of instances in runSpec. There are two cases: * There are missing instances, in that case marathon starts new instances * There are too many instances, in that case marathon kills overdue instances In second case, lock is supposed to be released only when overdue instances are dead. We encountered issues where lock was never released because KillStreamWatKillStreamWatcher.watchForKilledTasks() future was never ending. This is because of a typo in the code, making it wait for ALL instances to die, instead of just the overdue subset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale checks are done regularly, to validate that running instances
number matches expected number of instances in runSpec.
There are two cases:
instances
instances
In second case, lock is supposed to be released only when overdue instances
are dead. We encountered issues where lock was never released because
KillStreamWatKillStreamWatcher.watchForKilledTasks() future was never
ending. This is because of a typo in the code, making it wait for ALL
instances to die, instead of just the overdue subset.
What do you think?