Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count number of hops #1935

Merged
merged 26 commits into from May 13, 2024
Merged

Count number of hops #1935

merged 26 commits into from May 13, 2024

Conversation

DavIvek
Copy link
Contributor

@DavIvek DavIvek commented Apr 12, 2024

Description

To be able to limit number of hops in query, firstly we need to count number of hops.
Firstly, we want to count number of hops in DFS, BFS and classic expands. Every unit of work is counted as hop, including filtering on edge types, edge properties or visiting already processed nodes.

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • [FINAL GIT MESSAGE]

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • The total number of hops counted throughout the entire query is returned in the number_of_hops field in the summary.
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

cc @kgolubic

@DavIvek DavIvek added the Docs unnecessary Docs unnecessary label Apr 12, 2024
@DavIvek DavIvek self-assigned this Apr 12, 2024
@DavIvek DavIvek mentioned this pull request Apr 12, 2024
7 tasks
@DavIvek DavIvek marked this pull request as ready for review April 18, 2024 15:33
@DavIvek DavIvek marked this pull request as draft April 18, 2024 15:36
@DavIvek DavIvek marked this pull request as ready for review April 18, 2024 17:43
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavIvek A few minor fixes required, but overall looks good (this is the right size of a PR and the right first step 💪)

This reverts commit 0bb0363.
@DavIvek DavIvek requested a review from gitbuda April 19, 2024 11:01
Copy link
Contributor

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments but LGTM

src/query/context.hpp Outdated Show resolved Hide resolved
src/query/interpreter.cpp Outdated Show resolved Hide resolved
@DavIvek DavIvek added CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=core Run release build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=community -test=core Run community build and core tests on push labels May 6, 2024
@DavIvek DavIvek requested a review from Josipmrden May 6, 2024 11:28
@DavIvek DavIvek added this to the mg-v2.17.0 milestone May 9, 2024
@DavIvek DavIvek enabled auto-merge May 13, 2024 08:57
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all comments resolved -> 🚀

@DavIvek DavIvek added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@DavIvek DavIvek added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@DavIvek DavIvek added this pull request to the merge queue May 13, 2024
Merged via the queue into master with commit 64ff2c7 May 13, 2024
10 of 11 checks passed
@DavIvek DavIvek deleted the count-number-of-hops branch May 13, 2024 15:25
@DavIvek DavIvek added Docs - changelog only Docs - changelog only and removed Docs unnecessary Docs unnecessary labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs - changelog only Docs - changelog only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants